[MPlayer-dev-eng] [PATCH] Add fate test

[Reimar Döffinger]

On 9 Nov 2011, at 08:30, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> On 9 Nov 2011, at 02:43, Diego Biurrun <diego at biurrun.de> wrote:
> 
>> On Sun, Nov 06, 2011 at 11:04:10AM +0100, Reimar Döffinger wrote:
>>> a bit hackish, video only, some samples fail even when testing on a
>>> single configuration.
>> 
>>> --- Makefile    (revision 34309)
>>> +++ Makefile    (working copy)
>>> @@ -926,6 +926,7 @@
>>> 
>>> clean:
>>>   -$(MAKE) -C ffmpeg $@
>>> +    -$(MAKE) -C tests clean
>>>   -rm -f $(call ADD_ALL_DIRS,/*.o /*.a /*.ho /*~)
>>>   -rm -f $(call ADD_ALL_EXESUFS,mplayer mencoder)
>>> 
>>> @@ -1087,12 +1088,14 @@
>>> 
>>> +fatetest: mplayer$(EXESUF)
>>> +    $(MAKE) -C tests fatetest
>>> 
>>> 
>>> -include $(DEP_FILES) $(DRIVER_DEP_FILES) $(TESTS_DEP_FILES) $(TOOLS_DEP_FILES) $(DHAHELPER_DEP_FILES)
>>> 
>>> .PHONY: all doxygen *install* *tools drivers dhahelper*
>>> -.PHONY: checkheaders *clean tests check_checksums
>>> +.PHONY: checkheaders *clean tests check_checksums fatetest
>> 
>> I designed the build system non-recursive and monolithic on purpose.
>> 
>> tests/Makefile should be part of the main Makefile.
> 
> Well, including it should be no problem, but I really don't want everything in one single Makefile, that one is already almost as "nice" to get an overview of as mplayer.c
> I remember you complaining that people don't apply good programming principles to build systems, so this is a good point at applying the principle "independent stuff I different files" IMO.
> There's also some other minor annoyance like that it is convenient to run the test script from the tests directory, that's a bit more difficult with non-recursive make.

A different solution I'd be completely fine with - for now at least - is to have two completely separate Makefiles, then it is not recursive.
I do see (now) and agree that what I added to the main Makefile ended up being messy and broken.