[MPlayer-dev-eng] Small configure improvements

Diego Biurrun diego at biurrun.de
Tue May 31 17:15:35 CEST 2011


On Tue, May 31, 2011 at 01:18:30AM +0300, Ivan Kalvachev wrote:
> 
> I intend to commit them soon.

Don't do that, your build system patches usually require changes.

> --- configure	(revision 33527)
> +++ configure	(working copy)
> @@ -1679,6 +1679,12 @@
>  fi # icc
>  test "$cc_fail" = yes && die "unsupported compiler version"
>  
> +
> +#compiler check

pointless comment

> +echocheck "working compiler"
> +cflag_check "" || die "Compiler failed"

The error message is a little bit non-descript, just use the one
from the other configure.

> --- configure	(revision 33527)
> +++ configure	(working copy)
> @@ -2586,6 +2592,8 @@
>    warn_cflags=yes
>  fi
>  
> +cflag_check "-fno-tree-vectorize" && CFLAGS="$CFLAGS -fno-tree-vectorize"
> +
>  if test "$cc_vendor" = "gnu" ; then
>    cflag_check -Wundef && WARNFLAGS="-Wundef $WARNFLAGS"
>    cflag_check -std=gnu99 && WARN_CFLAGS="-std=gnu99 $WARN_CFLAGS"

This is a gcc-only option, so put that in the gcc section right below.

Diego


More information about the MPlayer-dev-eng mailing list