[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Nicolas George]

Le decadi 30 floréal, an CCXIX, Reimar Döffinger a écrit :
> I considered exit_mplayer a "hard abort".
> And I can't quite decide whether it is better or worse: If someone ever
> used the function in code that somehow might be called by exit_mplayer you
> can now get an endless recursion.

This is a valid concern, indeed.

> Some arbitrary value like INT_MAX (or rather some fixed constant that will
> always fit in an int) also has the advantage that behaviour will be the
> same on all systems.
> But either way I think there has been enough pointless discussion. I sure
> think that reusing the existing function is better (since it is tested and
> has several users), and that exiting on failure has no real advantages but
> has several issues including discouraging really good code but if I can't
> convince you just go ahead.

I rewrote the delogo patch without relying on new utility functions. Do you
like it better that way?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vf_delogo-allow-to-change-the-rectangle-based-on-the.patch
Type: text/x-diff
Size: 7833 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110522/1802b572/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110522/1802b572/attachment.asc>