[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Reimar Döffinger]

On 17 May 2011, at 16:29, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le duodi 22 floréal, an CCXIX, Nicolas George a écrit :
>>> Subject: [PATCH 1/3] Introduce the exit_player function in mencoder.
>>> Subject: [PATCH 2/3] Introduce mp_mem.[ch] for memory alloc helpers.
>>> Subject: [PATCH 3/3] vf_delogo: allow to change the rectangle based on the time
>> Ping?
> 
> Well, this is IMHO a very useful feature, I'd like to commit soon, if no one
> objects.

I still dislike the mp_mem all-around: I do not like those hard aborts, I do not like adding a new file with "generic" code that will be used only in one place (with a risk that this never changes, making it a useless maintenance burden) and I don't really like that the realloc integer overflow check is not done in the usual way (nelem > MAX / element_size), even though I at least currently can't think of a case where it would fail.


> 
> -- 
>  Nicolas George
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng