[MPlayer-dev-eng] [PATCH] MNG output support for MPlayer

[Stefan Schuermans]

Clément Bœsch wrote:
 > On Thu, May 12, 2011 at 12:02:38AM +0200, Stefan Schuermans wrote:
 >>>> +    /* we are initialized */
 >>>> +    vomng->b_is_init = 1;
 >>>> +
 >>> It took me quiet a few time to realize what the b meant… please
 >>> avoid that notation.
 >> Renamed to "is_init".
 >
 > Thank you. Of course, if you had done it for all the other i_* and p_*
 > that would have been awesome, but I don't really care. Your patch
 > looks fine.

I removed all the prefixes, because I do not want my code to make 
MPlayer less awesome that it is. :-)

 >> +    for (y = 0; y < hf; ++y)
 >
 > Just a nitpick while I'm at it: y++ is preferred (don't waste your
 > time re-sending a patch for this). Since this is not ++C code it
 > doesn't affect at all the generated code.

As I'm sending a new version of the patch anyway, I also changed all 
standalone prefix increments to postfix increments.

Best regards,
Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MPlayer-svn20110515-vomng.diff
Type: text/x-patch
Size: 22695 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110515/a1d13873/attachment.bin>