[MPlayer-dev-eng] [PATCH] Add support for 9-bit/10-bit H.264

[Reimar Döffinger]

On 11 May 2011, at 11:59, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
>>> I only tested with 10bit (and got wrong colours).
>> 
>> What did you test with? Worked fine for me with V-codecs/v210/v210....avi with
>> fglrx drivers and  also with other OpenGL drivers except for artefacts of
>> quality reduced to 2 bit.
> 
> 10bit works fine with r33453 (and your patch), but does not work (wrong colours)
> for r33452 (plus your patch).
> I guess this answers your search for "a system that actually provides
> GL_LUMINANCE16" ;-)
> 
> (But perhaps if I say "wrong colours" it is what you mean with "2 bit"?)

Yes, in that case what you saw was 2-bit yuv and not strictly wrong.
It can have a bit strange effects on colour, but for the sample I tried with it resulted in a basically black-and-white image with 4 brightness levels.
The good thing about this is that for people with cards that can output more than 8 bits that only with that revision actually started to work.
And btw. to be pedantic the correct constants are 64.0625 for 10 bit and 128.25 for 9 bit.
Not sure when I'll be able to implement it though, I am on holiday and don't have a proper PC with me.
And I'm not yet sure what the most same way is anyway, not to mention that I a, unsure which yuv= methods it can be made to work with.