[MPlayer-dev-eng] [PATCH] Windows GUI with mingw64 and cygwin revised part 2

[emild at cs.technion.ac.il]

Hi,

Quoting Ingo Br�ckl <ib at wupperonline.de>:

> Diego Biurrun wrote on Fri, 06 May 2011 15:28:53 +0200:
> 
> > On Fri, May 06, 2011 at 02:25:27PM +0200, Ingo Br�ckl wrote:
> >> Stephen Sheldon wrote on Fri, 6 May 2011 12:06:36 +0000 (UTC):
> >>
> >> > No, process.h is not required for CreateThread.
> >> > Here is the patch for CreateThread all by itself.
> >>
> >> If nobody objects, I will apply it shortly.
Sorry for the late comment, but is blindly replacing _beginthreadex() with
CreateThread() a good idea? AFAIK programs which use the MS C runtime library
should use _beginthreadex() instead of CreateThread() as the former does some
thread-specific initialization. Using plain CreateThread() with the MS C
runtime library can cause memory leaks. 

See also:

http://support.microsoft.com/kb/104641/en-us


> 
> > Do it right away.
> 
> Committed.
> 
> Ingo

                                                           Regards,
                                                                Emil
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>