[MPlayer-dev-eng] vo equalizer cleanup
Diego Biurrun
diego at biurrun.de
Thu May 5 09:31:07 CEST 2011
On Mon, May 02, 2011 at 02:35:05AM +0300, Ivan Kalvachev wrote:
>
> The patch causes few more warnings, but I think they could be fixed by
> using "const char *" in vo_xv_set/get_eq() (patch attached).
> Alternative method is making these functions take vf_equalizer
> directly.
>
> --- libvo/x11_common.h (revision 33346)
> +++ libvo/x11_common.h (working copy)
> @@ -102,8 +102,8 @@
>
> -int vo_xv_set_eq(uint32_t xv_port, char * name, int value);
> -int vo_xv_get_eq(uint32_t xv_port, char * name, int *value);
> +int vo_xv_set_eq(uint32_t xv_port, const char * name, int value);
> +int vo_xv_get_eq(uint32_t xv_port, const char * name, int *value);
It might even be 'const char * const name'. Does either form affect
the number of warnings? Either way patch should be OK.
Diego
More information about the MPlayer-dev-eng
mailing list