[MPlayer-dev-eng] [BUG] [PATCH] Ogg/Theora frametime broken on 0-length packets

[David Kuehling]

>>>>> "Carl" == Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
>> > > > http://mosquito.dyndns.tv/david/nanonote/theora-0packets.ogv
>> > > 
>> > > Actually, MPlayer does know how it should play it, it just thinks
>> > > it's not a good idea to do so because the video time-stamps
>> change > > too suddenly to it liking.  > > -mc 100 reduces the issue
>> significantly
>> > 
>> > That is still completely wrong, afaict.
>> > 
>> > mplayer -demuxer ogg -fps 24 plays the sample as expected (imo) and
>> much > better than vlc.
>> 
>> Huh? Like that the video is played in about 4 seconds instead of 33.

> svn di and git diff report an unpatched MPlayer here, above sample has
> md5sum 226e3b6537edb1941fe9c293e75e8485 for me.  Video plays ~8
> seconds with -demuxer ogg and ~33 seconds with mplayer -demuxer ogg
> -fps 24.

Note that -fps 24 has exactly the same effect as my patch: it skips the
frame duration computation based on delta-PTS, and instead uses a
constant frame duration of 1/24 (see video_read_frame()).

I'm not writing that to say that my patch was a good approach.  That was
a little short-sighted, fixing the ds_get_next_pts() would certainly be
better.

cheers,

David
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110501/b5fb26ee/attachment.asc>