[MPlayer-dev-eng] inline TranslateFilename()?

wucan wu.canus at gmail.com
Tue Mar 8 01:24:33 CET 2011


On 03/08/2011 04:49 AM, Ingo Brückl wrote:
> Could somebody please have a look at TranslateFilename() in
> gui/mplayer/gui_common.c? I see little reason to tag it 'inline'.
> It's big and calling it shouldn't be timing issue. So why 'inline'?
>
I had check it, there are 3 caller, so a inline seems not reasonable,
but if we push down the 3 caller into 1 caller, we could left it inline, 
and also make caller cleaner.
attachment is the patch, the c to cidx is messy really, have a better 
solution?
> Ingo
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng


-- 
wucan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gui_common_translatefilename_calling.patch
Type: text/x-patch
Size: 1304 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110308/9b92883f/attachment.bin>


More information about the MPlayer-dev-eng mailing list