[MPlayer-dev-eng] the great reformatting

Diego Biurrun diego at biurrun.de
Sat Mar 5 21:16:47 CET 2011


On Tue, Feb 22, 2011 at 10:34:25AM +0100, Ingo Brückl wrote:
> Clément Boesch wrote on Tue, 22 Feb 2011 00:00:38 +0100:
> > But, this is not enough too. In fact I was afraid uncrustify removed the
> > variable names from the prototypes here:
> 
> >> int fntFindID(char *);
> >> void fntFreeFont(void);
> >> int fntRead(char *, char *);
> >> txSample *fntRender(wItem *, int, char *);
> >> int fntTextWidth(int, char *);
> 
> > While in fact it was you :)
> 
> Oh, sorry for not mentioning. Yes, I'd like to remove the unnecessary
> variable names from header files (redundant and not needed by the compiler)
> unless of course this would be against the coding style.

It would - IMHO - be stupid to remove such valuable information, why
would you want to do such a thing?  Of course the compiler does not
care, but developers also read header files, not just compilers...

In any case such a change should not be done as part of an
uncrustification IMO.

Diego


More information about the MPlayer-dev-eng mailing list