[MPlayer-dev-eng] [RFC] run only toplevel FFmpeg makefile

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jun 26 20:40:07 CEST 2011


On Sun, Jun 26, 2011 at 03:51:58PM +0200, Diego Biurrun wrote:
> On Sun, Jun 26, 2011 at 11:49:52AM +0200, Reimar Döffinger wrote:
> > On Sun, Jun 26, 2011 at 11:32:42AM +0200, Reimar Döffinger wrote:
> > > While I consider the sublevel Makefiles really valuable and very much
> > > want to keep them working, I am not sure if there's any real interest.
> > > In case that not, I want to propose attached patch for review so
> > > that MPlayer will continue to build.
> > 
> > Sorry, uglier but closer to the current code and actually working
> > with parallel build.
> >  
> > --- Makefile	(revision 33727)
> > +++ Makefile	(working copy)
> > @@ -807,7 +807,7 @@
> >  
> >  $(FFMPEGLIBS): $(FFMPEGFILES) config.h
> > -	$(MAKE) -C $(@D)
> > +	$(MAKE) -C ffmpeg $(shell echo $@ | sed -e s#ffmpeg/##)
> 
> Make works but text transformation and substitution.  If you need to
> use the shell for such operations you are doing something wrong, have
> a look at
> 
> http://www.gnu.org/software/make/manual/html_node/Text-Functions.html#Text-Functions

Well, there were several reasons it was [RFC] not [PATCH], I just
got a bit tired trying to find the right stuff in the manual.
Concerning the subdir build: Considering how much the lack of it
interrupts my workflow and annoys me when I code stuff I think
I'd rather try to keep it around a while longer.


More information about the MPlayer-dev-eng mailing list