[MPlayer-dev-eng] [PATCH] Ignore 0-len packets for muxer prebuffering

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Jun 23 23:06:38 CEST 2011


On Thu, Jun 23, 2011 at 10:08:08PM +0200, Tobias Diedrich wrote:
> We should ignore packets of len 0, otherwise the muxer may have seen
> all streams but not have enough data to properly write the header.
> This fixes an issue where the libavformat muxer could not determine the
> image dimensions while writing the header and subsequently crash with
> a divison by zero.

The thing that is unclear is why we should change mencoder when it is
libavformat that crashes with a division by 0.
Also the description if "ignore packets of len 0" doesn't quite
match what it does, it seems _all_ code is actually being run for
them, only the muxbuf_seen flag (whatever that may do) is not set.
In particular I suspect this means there's only a change of behaviour
for initial 0-len packets.


More information about the MPlayer-dev-eng mailing list