[MPlayer-dev-eng] [PATCH] Increase movie_aspect max to 4.0

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Jun 21 19:32:46 CEST 2011


On Tue, Jun 21, 2011 at 12:57:31PM -0400, Steaphan Greene wrote:
> On 06/21/2011 12:50 PM, Nicolas George wrote:
> >Le septidi 27 prairial, an CCXIX, Steaphan Greene a écrit :
> >>With 16x9 side-by-side stereo (aspect=32:9, or 3.5555) movies around,
> >>the old max for -aspect of 3.0 is not sufficient.  Attached here is a
> >>1-character-change patch, from current SVN, increasing it to 4.0, which
> >>I hope will not be controversial.
> >
> >I don't have stereo content, but if there is 16:9 side-by-side, couldn't
> >there be also 2.39:1 too? Then, 4.0 would not be enough.
> 
> Yes, that's possible.  I have not personally seen greater than 32:9,
> so I was more conservative with this, but doubling this max (to 6.0)
> might be the more appropriate fix.  I don't know why this max is
> there, so I didn't want to increase it more than was necessary.

I think the only real point is to enforce sensible values,
avoiding reports like "my video is all black" or "mplayer creates
a window much larger than my screen and I can't figure out how
to close it" because someone used -aspect 1000.
I decided to just go ahead and expand the range from 0.1 to 10,
that is symmetric and hopefully large enough.


More information about the MPlayer-dev-eng mailing list