[MPlayer-dev-eng] [PATCH] Stereo3D: Row-Interleave Output Support

[Steaphan Greene]

On 06/19/2011 04:35 AM, Reimar Döffinger wrote:
> No, I don't think so. Applied, thanks.
> I had to remove some trailing whitespace from the man-page though.
> I also changed the example with scale a bit, please correct me
> if it's wrong (you had ",scale=..", but scale must come first, so
> that made no sense to me).

Thanks.

You're right.  I was apparently confused when I first wrote that (doing
too many things at once, sorry).  Good catch.  Your example is not quite
right though, as you need two formats for -vf stereo3d (input and
output), and I wrote an 'x' instead of the ':' needed for width:height
in the scale filter.  Also, unlike what I originally said, only the
height scaling is important.

Also, while confirming my corrected example, I discovered that the
memcpy_pic function has an auto-check for certain cases that actually
disables this interleaving if the stride is the same in the input and
the output.  This is true for above-below videos, for example, so I
changed it to call memcpy_pic2 directly, with an override of this check
in the case of row-skipping.  This corrects this problem.

I've attached a patch (to current SVN, r33659) which this fixes this
problem, corrects the new man page note, and also includes my earlier
patch to increase the maximum aspect ratio to the -aspect option to 4.0
(which is required to use this to play the many side-by-side movies
which are half-width).

I believe these are all correct, and this patch should be good to apply
now.  Of course, I'm apparently getting senile in my old age, so please
do check this over carefully, in case I was confused again. ;)

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer_stereo3d_row_interleave_output_only.r2.patch
Type: text/x-patch
Size: 2896 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110619/ccd094cc/attachment.bin>