[MPlayer-dev-eng] GUI's icon - a X11 issue?

Ingo Brückl ib at wupperonline.de
Mon Jun 13 12:27:33 CEST 2011


Steaphan Greene wrote on Sun, 12 Jun 2011 16:18:23 -0400:

> And, I also found a bug in a later section of code dealing with this
> icon (a "long" was assumed to be 32-bits), which I have also corrected
> in this patch.

> +++ gui/wm/ws.c (working copy)
> @@ -1253,7 +1253,7 @@
>  void wsSetIcon( Display * dsp,Window win,Pixmap icon,Pixmap mask )
>  {
>   XWMHints * wm;
> - long      data[2];
> + uint32_t   data[2];

Wouldn't it be better to use CARD32?

Ingo


More information about the MPlayer-dev-eng mailing list