[MPlayer-dev-eng] [PATCHES] vobsub back to the future

[Reimar Döffinger]

On Sat, Jun 11, 2011 at 06:40:38PM +0200, Clément Bœsch wrote:
> Two patches that were lying in a forgotten directory attached. I remember
> sending them a while ago, but I can't remember the outcome :)

Hm, I think the second one changes the parsing from unsigned to signed.
Or rather, strtoul behaves rather strangely for negative input.
I suspect it doesn't really make things worse, but I don't know.
Error detection also changes slightly.
E.g. previously a line ending with
filepos: z
would have failed, now it would be interpreted as filepos 0 without
causing an error.
Admittedly it's not much worse, because before
filepos: 0z
would still have gone through...
So overall I am ok with it, but the new code isn't perfect either.