[MPlayer-dev-eng] [PATCH] Improve the readability of dynamic labels which scroll

Nicolas George nicolas.george at normalesup.org
Sun Jan 30 17:23:31 CET 2011


Le primidi 11 pluviôse, an CCXIX, Ingo Brückl a écrit :
>						    (BTW, the diff of gui/app.h
> shows the disadvantage of pretty-printing. Although only a few lines added,
> the diff is lengthy and hard to read.)

The usual policy for MPlayer and FFmpeg is to split the patch in two: first
functional changes, and then whitespace changes, even if it means to have a
badly indented commit for a short period of time.

For example if

	frobnicate(foo);

is to become:

	if (bar) {
	    frobnicate(foo);
	} else {
	    frobnicate(foo + 1);
	}

you do an intermediate commit:

	if (bar) {
	frobnicate(foo);
	} else {
	    frobnicate(foo + 1);
	}

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110130/d7b21ed9/attachment.pgp>


More information about the MPlayer-dev-eng mailing list