[MPlayer-dev-eng] [PATCH] Fractional part of time stamp in OSD

Nicolas George nicolas.george at normalesup.org
Sat Jan 29 13:23:38 CET 2011


Le decadi 10 pluviôse, an CCXIX, Christian a écrit :
> If you prefer to have a patch without the German man-page, just let me know.

I do not think this is necessary at all.

> Reformatted to 78 columns.

Thanks.

> +                snprintf(fractions_text, sizeof(fractions_text), ".%02d", 
> +		      (int)( (mpctx->sh_video->pts - pts)* 100 + 0.5) % 100);

> +                //print fractions by estimating the frame count within the
> +	        //second

There are tabs around the place, and the indentation is sometimes odd. In
particular:

	frobnicate(foo,
	           bar);

is supposed to be indented like that, aligned with the opening parenthesis.

I do not think it is necessary to send a new patch for that if there are no
other changes, just keep it in mind for the next time.

Apart from that, I think this patch could be applied. Any other advice?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110129/8ee739d9/attachment.pgp>


More information about the MPlayer-dev-eng mailing list