[MPlayer-dev-eng] [PATCH] Translate messages

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jan 23 20:32:09 CET 2011


On Sun, Jan 23, 2011 at 07:55:30PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sat, 22 Jan 2011 11:10:08 +0100:
> 
> > I won't object but I don't like it. You are adding complexity for stuff
> > that simply has no future. The only say path forward is to get rid of
> > _everything_ that isn't UTF-8.
> 
> Diego Biurrun wrote on Sat, 22 Jan 2011 19:56:49 +0100:
> 
> > This makes no sense IMO, the only sane default in the 21st century is
> > UTF-8. ISO-8859-1 is not even used by the majority of MPlayer users I
> > believe.
> 
> Ok, you both are right and thank you for the gentle pushing which led to a
> new patch that enables UTF-8 character definition in the font description
> file and UTF-8 character output from the font file to the GUI. It is
> compatible with previous font definitions.
> 
> Again, for easy reading the diff is from r32799, i.e. before I've made my
> first change concerning message translation, and with --ignore-space-change.
> 
> Assuming I will commit at some point, should I commit twice, i.e. first undo
> my first message translation attempt and then commit the UTF-8 patch or
> commit changes from the actual revision, i.e. having all in one commit?

Whatever you prefer I'd say.
I haven't really reviewed, but your fntGetFnt has neither a helpful name
nor any documentation, please improve on at least one.


More information about the MPlayer-dev-eng mailing list