[MPlayer-dev-eng] [PATCH] Avoid raising error when trying to load a vobsub.

[Clément Bœsch]

On Sat, Jan 22, 2011 at 12:06:21PM +0100, Reimar Döffinger wrote:
> On Sat, Jan 22, 2011 at 11:33:41AM +0100, Clément Bœsch wrote:
> > On Sat, Jan 22, 2011 at 11:15:06AM +0100, Reimar Döffinger wrote:
> > > On Fri, Jan 21, 2011 at 10:54:27PM +0100, Clément Bœsch wrote:
> > > > On Thu, Jan 13, 2011 at 12:38:06AM +0100, Clément Bœsch wrote:
> > > > > [...]
> > > > > From 3ac94829563a5caba4e14457ea5a95cf03948736 Mon Sep 17 00:00:00 2001
> > > > > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> > > > > Date: Thu, 13 Jan 2011 00:34:38 +0100
> > > > > Subject: [PATCH] Avoid raising error when trying to load a vobsub.
> > > > > 
> > > > 
> > > > Ping (j-3)
> > > 
> > > I haven't checked how vobsubs even appear there, as I understand it normal
> > > subs are loaded with -sub and vobsubs with -vobsub so there's no reason
> > > for that code to be executed?
> > 
> > MicroDVD and vobsub share the same extension .sub, so when tracking
> > text subtitles, binary .sub also get opened.
> 
> Ah, ok. In that case maybe add a comment that it's only to suppress a warning
> for the case where we got a vobsub sub into the text-sub autoload list.

Ok.

> What happens though if someone does -sub somevobsub, is it ignored without
> warning, too?
> 

Yes, and indeed this is problematic… I'm not sure how to handle this.
Checking for the existence of a corresponding .idx in append_dir_subtitles
may not that bad then. Any better idea?

-- 
Clément B.