[MPlayer-dev-eng] [PATCH] Add mp_strings.c with mp_asprintf function.

[Diego Biurrun]

On Wed, Jan 12, 2011 at 11:44:32PM +0100, Clément Bœsch wrote:
> 
> I just made a small equivalent to the GNU asprintf function (since I
> suppose it's not available on all system supported by mplayer) in order to
> use it in a few places instead of fixed size buffers like BUFLENGTH in
> some vo (jpeg, png, …) and maybe a few other PATH_MAX we were speaking a
> while ago.

The traditional place for this is the osdep/ directory.  You should also
check in configure for its presence.

> --- /dev/null
> +++ b/mp_strings.c
> @@ -0,0 +1,49 @@
> +
> +#include <stdlib.h>
> +#include <stdarg.h>
> +#include <stdio.h>
> +#include "mp_strings.h"

nit: It's nice to separate system and local header #include by an empty line.

> --- /dev/null
> +++ b/mp_strings.h
> @@ -0,0 +1,26 @@
> +
> +#ifndef MP_STRINGS_H
> +# define MP_STRINGS_H
> +
> +int mp_asprintf(char **strp, const char *fmt, ...);
> +
> +#endif

  #ifndef MPLAYER_MP_STRINGS_H
  #define MPLAYER_MP_STRINGS_H

  #endif /* MPLAYER_MP_STRINGS_H */

Diego