[MPlayer-dev-eng] [PATCHES] VOBsub cleanup

[Diego Biurrun]

On Tue, Jan 11, 2011 at 01:38:26AM +0100, Clément Bœsch wrote:
> 
> 1) Since subreader.c tends to "load" instead of "read" subtitles files,
>    is it ok to rename it to something like subloader.c? I'm not only
>    referring to my load_* functions, but even sub_read_* functions are not
>    really reading, but much more loading subtitles using buffers…

Fine with me if you prefer.

> 4) VOBsub has a not-working-that-much RAR support; is it fine to drop it
>    in case we move to FFmpeg decoders?

Maybe ask around on -users.

> --- a/sub/subreader.c
> +++ b/sub/subreader.c
> @@ -2100,6 +2101,50 @@ void load_subtitles(const char *fname, int fps, void add_f(char *, float, int))
>  
> +/**
> + * @brief Load VOB subtitle matching the subtitle filename

nit1: Please use proper punctuation in Doxygen comments.

Diego