[MPlayer-dev-eng] [PATCHES] VOBsub cleanup
Reimar.Doeffinger at gmx.de
Mon Jan 17 21:04:43 CET 2011
On Tue, Jan 11, 2011 at 01:38:26AM +0100, Clément Bœsch wrote:
> 1) Since subreader.c tends to "load" instead of "read" subtitles files,
> is it ok to rename it to something like subloader.c? I'm not only
> referring to my load_* functions, but even sub_read_* functions are not
> really reading, but much more loading subtitles using buffers…
I don't see the point/difference. The do read subtitles (stream_read_line etc.),
but of course they also load it. One without the other makes little sense.
> 2) load_vob_subtitle, just like the other hack, seems at the moment unable
> to load more than one subtitle at a time; can anyone confirm that? It
> seems not very problematic since there is generally a single vobsub
> file for multiple language but just to know :)
In theory you should be able to load one subtitle per vo_vobsub struct.
However having more than one probably isn't tested at all, and changing
vo_vobsubs during playback might be real tricky.
However, it means it would be a good idea if load_vob_subtitle returned
the allocated vobsub struct instead of assigning it to vo_vobsub itself.
> 3) If this patch gets applied, I'll edit a bit my -sub-paths patch to
> allow vobsub to be loaded in specified directories, but it will only
> load the first find one (if you confirm (2)); it is fine?
It is fine (though as said I'd appreciate it if you try to ensure you make
doing this properly not harder, i.e. keep assinging vo_vobsub as much top-level
as reasonably possible).
> 4) VOBsub has a not-working-that-much RAR support; is it fine to drop it
> in case we move to FFmpeg decoders?
Dropping features is not appreciated much.
Also last I checked quite a few people seemed to be using it, so it shouldn't
be working that badly...
More information about the MPlayer-dev-eng