[MPlayer-dev-eng] [PATCH] Get rid of the "main" label

Clément Bœsch ubitux at gmail.com
Sat Jan 8 18:50:34 CET 2011


On Sat, Jan 08, 2011 at 05:41:38PM +0100, Reimar Döffinger wrote:
> On 25 Dec 2010, at 17:29, Clément Bœsch <ubitux at gmail.com> wrote:
> > I'd like a feedback on this patch: there is still a "main" label in
> > mplayer.c. This is patch to get rid of it.
> 
> If you only want to get rid of it, just use a if(sh_video) block there
> and leave everything else unchanged. I don't like changing more code
> than necessary at least not if there seems to be no good reason to do
> it...

It's not enough since there is two goto main. I would have done it like
you said in case of just one.

-- 
Clément B.


More information about the MPlayer-dev-eng mailing list