[MPlayer-dev-eng] [PATCH] Subtitles directories

[Diego Biurrun]

On Mon, Jan 03, 2011 at 09:46:50PM +0100, Clément Bœsch wrote:
> On Mon, Jan 03, 2011 at 09:19:22PM +0100, Diego Biurrun wrote:
> > On Mon, Jan 03, 2011 at 09:02:57PM +0100, Clément Bœsch wrote:
> > > --- a/DOCS/man/en/mplayer.1
> > > +++ b/DOCS/man/en/mplayer.1
> > > @@ -2625,6 +2625,27 @@ Guess the encoding for Polish, fall back on cp1250.
> > >  .PD 1
> > >  .
> > >  .TP
> > > +.B \-subdirs <dirname1,dirname2,...>
> > > +Specify extra subtitle directories to track in the media directory.
> > 
> > "subdir" is a subdirectory, not a subtitle-directory.  I think you should
> > come up with another name like "subsdir" or "subtitledir" or similar.
> 
> I took the "sub" prefix because of the rest of the subtitles options. I
> should have called it -sub-dirs btw, but it does not solve the issue here.
> 
> I could call it -subtitles-dir, but any option starting with "-subtitle"
> will likely break the consistency of the subtitles options.
> 
> Then, maybe -sub-paths just like Uoti proposed a while ago would be fine?
> I'm not a native english speaker, but if I'm not wrong, "sub-path" does
> not exist so it should be fine. Can you confirm?

Yes, that's better.

Diego