[MPlayer-dev-eng] the great reformatting

[Ingo Brückl]

Diego Biurrun wrote on Tue, 15 Feb 2011 10:25:44 +0100:

>> But the config options are v0.54?

> It evolved from a config for v0.54, maybe I attached the wrong file,
> will doublecheck again.

I was just afraid there might be new options unconsidered.

>> No new line after a block of variable definitions?
>> -------------------------------------------------
>> void fntFreeFont(void)
>> {
>>     int i;
>>     for (i = 0; i < MAX_FONTS; i++)
>> -------------------------------------------------

> Hmm, I'll look into the holy book again.

nl_func_var_def_blk

>> This is a strange amount of spaces between ) and { in font.c (could be a bug):
>> -------------------------------------------------
>>         } else if (!strcmp(command, "image"))     {
>> -------------------------------------------------

> That's a bug in uncrustify.  Which file triggered it?

gui/skin/font.c

>> No new line after the case label?
>> -------------------------------------------------
>>         case fntAlignLeft:   dx = 0;
>>             break;
>> -------------------------------------------------
>>
>> Similar in fs.c:
>> -------------------------------------------------
>>     default: return;
>> -------------------------------------------------

> That looks like a bug in the configuration.  Which file
> triggered it?

nl_after_case

The files are gui/skin/font.c and gui/mplayer/gtk/fs.c.

And additional question: What about new lines before and after control
statements, i.e.:

  a = b;
  c = d;
  if (a == c) {
      foo();
      bar();
  }
  while (b == d) {
      bar();
      foo();
  }
  x = a;
  y = b;

vs. (favoured?):

  a = b;
  c = d;

  if (a == c) {
      foo();
      bar();
  }

  while (b == d) {
      bar();
      foo();
  }

  x = a;
  y = b;

Ingo