[MPlayer-dev-eng] To format, or not to format

Ingo Brückl ib at wupperonline.de
Sun Feb 13 11:02:53 CET 2011


I'm currently looking over the gui source files to both understand how all
works and fix some bugs. Although I try to follow the programming style I
find, it's difficult because there doesn't really seem to be one. Almost each
file and even within a file often two consecutive lines have different styles.

Changing the formattings of whole files is annoying in terms of a versioning
control system, but understanding and maintenance would be much easier.

As I'm done with font.{h,c} now, I was thinking whether I could/should
reformat whole source files after I'm done with them and start with
font.{h,c} now. That way we only have one (but big) commit per file which
only reformats it.

The alternative, of course, is to not reformat and deal with the mixed style
further on.

Opinions?

Ingo


More information about the MPlayer-dev-eng mailing list