[MPlayer-dev-eng] [PATCH] More warnings

[Reimar Döffinger]

On Sun, Feb 06, 2011 at 09:50:07PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sat, 5 Feb 2011 18:51:56 +0100:
> 
> > IMO -Wextr mostly enables useless stuff while things that IMO should
> > always be on is still missing. I am talking specifically about
> > -Wcast-qual -Wwrite-strings -Wundef -Wmissing-prototypes
> 
> The extra warnings option doesn't change anything from the existing warnings,
> it just *adds*, i.e. in total we'll end up with:

What I was trying to say is that IMO you are adding the most useless
warnings out of those available.

> Concerning -Wcast-qual and -Wwrite-strings: When using these you have to very
> carefullly distinguish between char * and const char * which could mean a lot
> of fixes because this usually isn't done in C programs. Could be a nuisance
> when you need to call old char * functions with new const char * variables,

Both of these almost always indicate really bad design or an error.
The few cases where they don't are easy enough to ignore.