[MPlayer-dev-eng] [PATCH] Simplify frees in load_vob_subtitle.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Feb 6 12:00:00 CET 2011


On Sun, Feb 06, 2011 at 12:22:16AM +0100, Clément Bœsch wrote:
> > Next, there is a NULL check missing for the very last mp_path_join.
> 
> It does not really matter since the pointer is checked in the
> add_subtitles function, but fixed anyway since the add_f function can be
> something else.

Would be better to apply separately though, since that part of
the patch does not agree with the commit message.

> > could also be handled like
> > res = add_f(psub, ifo, 0, spu);
> > free(psub);
> > if (res)
> >     goto out;
> 
> Sure, why not. Patch updated.

Looks good, by choosing a better name then "res" it actually
makes things easier to understand.


More information about the MPlayer-dev-eng mailing list