[MPlayer-dev-eng] [PATCH] More warnings

[Reimar Döffinger]

On Thu, Feb 03, 2011 at 02:20:37AM +0100, Ingo Brückl wrote:
> @@ -2579,7 +2583,12 @@
>      CFLAGS="-O2 $_march $_mcpu $_pipe"
>    else
>      CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer"
> -    WARNFLAGS="-Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls"
> +    if test "$_extra_warnings" = "yes"; then
> +      EXTRAWARN="-Wextra -Wcast-align"
> +    else
> +      EXTRAWARN="-Wno-switch -Wno-parentheses"
> +    fi

IMO -Wextr mostly enables useless stuff while things that IMO should
always be on is still missing. I am talking specifically about
-Wcast-qual -Wwrite-strings -Wundef -Wmissing-prototypes