[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Nicolas George]

Le quartidi 14 pluviôse, an CCXIX, Reimar Döffinger a écrit :
> Adding a dependency on the subreader isn't that great

Inside mplayer, the subreader is included inconditionnally. I suppose you
are thinking about the effort to make mpcodecs a stand-alone library?

>							and the pts
> you have in the video filter is not at all realiable.

Are you sure about that? I think I read exactly the opposite. In particular,
I believe that ASS chose to use it because it was deemed _more_ reliable
than the global PTS, especially if there are framerate-modifying filters.

> I consider it likely that a custom format using frame numbers
> would work better in several aspects and probably even need less
> code.

I really do not like the idea of a custom format: not only does it make new
code, and therefore new bugs, but also it prevents the users from using
existing tools to manipulate the script. There are a lot of editors for text
subtitles, there would not be for a custom format.

If we want to avoid depending from the subreader in the video filters, I can
see another, more generic solution:

- make vf_delogo accept a control message to change the rectangle;

- add the corresponding slave command;

- create a system for time-based scripted slave commands.

This is more work, but I think it may be worth it. What do you think about
it?

Regards,

-- 
  Nicolas George