[MPlayer-dev-eng] [PATCH] smil params support is added.

[Diego Biurrun]

On Wed, Feb 02, 2011 at 07:26:57PM +0100, Clément Bœsch wrote:
> On Wed, Feb 02, 2011 at 12:43:46PM +0600, Andrei Katsuk wrote:
> > The new patch is attached to this email.
> > --- grouplist.c	(revision 0)
> > +++ grouplist.c	(revision 0)
> > @@ -0,0 +1,219 @@
> > +/**
> > + * @brief Append an item after its siblings.
> > + * @param pl param list
> > + * @param entry Item to append
> 
> Do not forget the period (on other doctypes too).

Actually, it's preferable to not end in a period when it it
not a sentence.

> > --- playtreeparser.c	(revision 32825)
> > +++ playtreeparser.c	(working copy)
> > @@ -464,14 +467,266 @@
> > +
> > +static int
> > +unescape_elem_cmp(const void* a, const void* b)
> > +{
> > +  const struct unescape_elem *ea = (const struct unescape_elem *) a;
> > +  const struct unescape_elem *eb = (const struct unescape_elem *) b;
> 
> Is the cast needed?

No.  void* is compatible with any pointer type in C.

Diego