[MPlayer-dev-eng] [PATCH] More warnings

Ingo Brückl ib at wupperonline.de
Wed Feb 2 23:15:21 CET 2011


Clément Boesch wrote on Wed, 2 Feb 2011 21:33:34 +0100:

>> I regard warnings on "if (a=0)",

> Yes, but imo you should notice there is a problem _very_ quickly :)

But that's what warnings are for. To tell me *before* I have to notice that
something doesn't work as I expected that something may not work as I expect.

>> unused parameters,

> This is extremely annoying when you have a callback system...

(void) them and both compiler and programmer see that they are unused on
purpose.

>> comparison between signed and unsigned (for example) as quite useful.

> This is annoying when doing something like for (int i = 0; i < sizeof(...

Well, maybe int is wrong then. ;-)

Ingo


More information about the MPlayer-dev-eng mailing list