[MPlayer-dev-eng] [PATCH] Enhanced Video Renderer (EVR)

[Georgi Petrov]

On Wed, Feb 2, 2011 at 9:33 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Wed, Feb 02, 2011 at 09:16:21PM +0200, Georgi Petrov wrote:
>> > I'm all for splitting patches, but they should still do at least
>> > something useful.
>> > If feel strongly about having this stub in SVN I can accept that,
>> > but at the very least preinit should fail with a message what is
>> > going on.
>> > Otherwise there's a risk that in two years we still will have users
>> > complaining that -vo evr does not work for them and they somehow
>> > ended up with an ancient version that does have this stub and probably
>> > will crash in a funny way without any useful info.
>>
>> I attach a new patch, where preinit fails and a error message is
>> displayed. The point of this "empty" patch is to have at least some
>> starting point in the future. I will add new features very quickly in
>> the following days.
>
> If you prefer it that way, fine.
> About the documentation though:
> We generally do not have doxygen stuff on things like preinit, config etc.
> because what these functions do is part of the API and should be documented
> in one place.
> If we had them documented in every single vo that's not just a waste of bytes
> but also fixing any mistakes would be a huge pain.
> Also both MPlayer and FFmpeg the documentation text on the line after
> the /**, i.e.
> /**
>  * @brief
> instead of
> /** @brief
> But please do not send an extra patch for that (in case you change it).

Ok, I will change the @brief lines style for EVR related functions. Do
you want me to remove the doxygen stuff from libvo functions in the
end?

Is the patch finally ready for prime time? If so, who will submit it?
I guess I still have permissions to commit. Should I commit or you
will?