[MPlayer-dev-eng] [PATCH] More warnings

Ingo Brückl ib at wupperonline.de
Wed Feb 2 20:53:07 CET 2011


Clément,
Diego,
Reimar,

I didn't intend to bother anybody. As the patch should only affect gui/ I
didn't see problems. But ok, I can go with the other methods suggested.

Clément, I agree on fixing existing warnings first. This is what I did in
gui/. It's free of warnings now, but there are still lines worth clarifying
where compiler and programmer may not be of one mind.

Yes Diego, -Wall is global in CFLAGS, but some of its options are switched
off there. --enable-extra-warnings is a good idea, but I do not want to start
a discussion on which warnings are good and which are not.

If -W{all,extra} doesn't reset warnings, Reimar, I do not lose any defaults,
only get additional ones. So -Wall doesn't affect warnings that should be
enabled and already are.

I regard warnings on "if (a=0)", unused parameters, comparison between signed
and unsigned (for example) as quite useful.

Ingo


More information about the MPlayer-dev-eng mailing list