[MPlayer-dev-eng] [PATCH] smil params support is added.

Wed Feb 2 19:44:49 CET 2011

On Fri, Jan 28, 2011 at 10:23:23AM +0600, Andrei Katsuk wrote:
> Hi,
> Currently, when parsing a SMIL playlist file, MPlayer is
> support only <media>, <video> <audio> src tags.
> 
> Attached patch adds support of param tag like:
> 
> <video src="test.avi" >
> <param name="additional-param1" value="additional-value1"/>
> <param name="additional-param2" value="additional-value2"/>
> </video>
> 
> Also paramGroup support is added:
> 
> <paramGroup xml:id="testgroup">
> <param name="additional-param1" value="additional-value1"/>
> <param name="additional-param2" value="additional-value2"/>
> </paramGroup>
> </head>
> <body>
> <ref src="test.avi" paramGroup="tesgroup">

You didn't really say what the purpose of parsing that is/what
you do with the info you parse.
Apart from that I have to admit I am not very enthusiastic about
more than 200 lines of (most likely) security-critical code
for a feature that to my knowledge nobody has ever requested
so far.