[MPlayer-dev-eng] [PATCH] Enhanced Video Renderer (EVR)

[Diego Biurrun]

On Wed, Feb 02, 2011 at 02:20:45PM +0200, Georgi Petrov wrote:
> On Wed, Feb 2, 2011 at 2:14 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Feb 01, 2011 at 08:54:08PM +0200, Georgi Petrov wrote:
> >> Please ignore the patch from the beginning of the thread. I forgot
> >> something. Now I'm sending an improved one.
> >>
> >> /**
> >>  * This file has no copyright assigned and is placed in the Public Domain.
> >>  * This file is part of the w64 mingw-runtime package.
> >>  * No warranty is given; refer to the file DISCLAIMER.PD within this package.
> >>  */
> >> #ifndef _INC_EVR
> >> #define _INC_EVR
> >>
> >> #if (_WIN32_WINNT >= 0x0600)
> >>
> >> #ifdef __cplusplus
> >> extern "C" {
> >> #endif
> >>
> >> #if (_WIN32_WINNT >= 0x0601)
> >> typedef enum _EVRFilterConfig_Prefs {
> >>   EVRFilterConfigPrefs_EnableQoS   = 0x00000001,
> >>   EVRFilterConfigPrefs_Mask        = 0x00000001
> >> } EVRFilterConfigPrefs;
> >> #endif /*(_WIN32_WINNT >= 0x0601)*/
> >
> > minor nit: You mix 2 and 4 space indentation in the file.
> 
> This is the mingw-w64 evr.h file. Is it being reviewed as well? I will
> fix it, but I don't understand - do you check it because you want to
> include it in mphq? The latest evr.patch in this thread doesn't
> include evr.h as part of MPlayer. Of course, I will indent it and make
> it look okay if it is to be included.

It was just a minor thing I noticed and decided I might as well mention..

Diego