[MPlayer-dev-eng] [PATCH] vd_mpng.c compatibility with libpng 1.5

[Clément Bœsch]

On Tue, Feb 01, 2011 at 08:20:25PM +0100, Reimar Döffinger wrote:
> On Tue, Feb 01, 2011 at 04:35:12PM +0100, Diego Biurrun wrote:
> > On Tue, Feb 01, 2011 at 04:31:19PM +0100, Clément Bœsch wrote:
> > > On Tue, Feb 01, 2011 at 04:21:50PM +0100, Diego Biurrun wrote:
> > > > On Tue, Feb 01, 2011 at 05:02:46AM +0100, Gianluigi Tiesi wrote:
> > > > > 
> > > > > recently released libpng 1.5 made private some members used by vd_mpng.c code.
> > > > > There are getters also in my linux 1.2.44
> > > > > Some tests should be made anyway
> > > > 
> > > > What you write confuses me.  Do you mean libpng 1.2.44?  Does your
> > > > patched version work with 1.5 or with both 1.2.44 and 1.5?
> > > 
> > > If I understand him well, the getters are needed for 1.5, but anyway
> > > available on 1.2.44, so this change does not break anything. I'll apply
> > > and test the patch tonight. If it works, I'll apply it in 3 days.
> > 
> > If you can test it and it works, apply right away.
> 
> Yes, since it's already implemented.
> However there is no point in vd_mpng and I think in the libpng support
> in general so just making detection fail on newer versions and
> also making libpng disabled by default IMO would have been enough
> of a solution.

Tested and applied. Since removing things take a long time to be done, I
think it's wise to fix this until it is removed.

Thanks Gianluigi Tiesi for the patch.

-- 
Clément B.