[MPlayer-dev-eng] [PATCH 2/2] av_helpers: show libav* version and configuration.

[Nicolas George]

Le tridi 3 nivôse, an CCXX, Reimar Döffinger a écrit :
> First, function is called show_av_version but it prints "Init".
> IMO that's confusing, it could just drop the "Init" part.

Ok.

> Next, it would be far more readable without all the snprintf.
> Something like
<snip>

That's true.

> Note that IMHO the names "st" and "dl" are not ideal.

I wanted to be consistent with configure terms.

>				 (even if the internal+dynamic version
> does not exist and external+static will probably need some hacks to
> get working).

Actually, external+static seems to work just fine out of the box.


Regarding the removal of avcodec_init:
> I don't mind, but I don't know if it might not hurt some distros if
> they try to link against some older version (I have no idea when this
> change was made in FFmpeg).

avcodec_init has been deprecated five months ago, but it has been useless
since three years. As mplayer can usually not be built against a four months
old ffmpeg, I believe it is safe to remove it.

commit 7221139ba0486c24afeac1f41ba97c75f58046b9
Author: Anton Khirnov <anton at khirnov.net>
Date:   Wed Aug 10 09:50:00 2011 +0200

    lavc: make avcodec_init() static on next bump.
    
    It's called from avcodec_register() anyway, so there's no reason for it
    to be public.

commit 7a961a46ba28e49f88ff0e81b96395c96b424634
Author: Stefano Sabatini <stefano.sabatini-lala at poste.it>
Date:   Sun Dec 14 20:04:00 2008 +0000

    Make register_avcodec() call avcodec_init().
    
    This avoids the possibility to use a registered codec without first
    initializing libavcodec, which resulted in unexpected behavior.
    
    Originally committed as revision 16131 to svn://svn.ffmpeg.org/ffmpeg/trunk


Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111224/a42688c9/attachment.asc>