[MPlayer-dev-eng] [PATCH] Enable gui slave commands

Ingo Brückl ib at wupperonline.de
Sun Dec 11 12:10:20 CET 2011


Reimar Döffinger wrote on Sat, 10 Dec 2011 21:49:50 +0100:

> On Fri, Dec 09, 2011 at 04:42:32PM +0100, Ingo Brückl wrote:
>> Something like this has been remove in r31378, but in order for slackers to
>> be able to operate the GUI with a remote control, we need it. I tried to
>> minimize the impact on non-gui files and think I found a neat solution (first
>> patch).

> You shouldn't need the ifdefs in input.

I assume you mean (only) input.h?

> And obviously you should update the slave.txt documentation.

Didn't I?

> I'd also prefer if you'd cast to "const char *" instead of "char *" if
> possible.

Sure.

Would you prefer two separate commits (MPlayer part and GUI part) or one?

Ingo


More information about the MPlayer-dev-eng mailing list