[MPlayer-dev-eng] [HACK/RFC] libass without fribidi

[Reimar Döffinger]

On Mon, Dec 05, 2011 at 09:02:23PM +0900, KO Myung-Hun wrote:
> > ===================================================================
> > --- libass/ass_shaper.h	(revision 34388)
> > +++ libass/ass_shaper.h	(working copy)
> > @@ -21,7 +21,12 @@
> >  
> >  #include "config.h"
> >  
> > +#ifdef CONFIG_FRIBIDI
> >  #include <fribidi/fribidi.h>
> > +#else
> > +typedef int FriBidiParType;
> > +typedef int FriBidiStrIndex;
> > +#endif
> >  #include "ass_render.h"
> >  
> 
> Is there a special reason typedefing only these two types ?

They are the only ones used in the header.

> Why don't you guard all the FriBidi stuffs with CONFIG_FRIBIDI ?

Because I wanted to keep it minimal.
And IMO it's a rather bad idea API-design-wise to have this header
depend on Fribidi anyway, so in case someone upstream would be
interested this would give a slight disincentive against making the
header depend even more on fribidi.