[MPlayer-dev-eng] [PATCH rev] windows gui about box

[Alexander Strasser]

Hi Ingo!

Ingo Brückl wrote:
> Stephen Sheldon wrote on Sun, 28 Aug 2011 23:32:07 +0000 (UTC):
> 
> > +static void display_about_box(HWND hWnd)
> > +{
> > +    char about_msg[512];
> > +    snprintf(about_msg, sizeof(about_msg), MP_TITLE, "MPlayer");
> > +    MessageBox(hWnd, about_msg, "About", MB_OK);
> > +}
> 
> I'd prefer putting the statements right into handlemsg(), avoiding an extra
> function.

  FWIW I prefer it the other way (like it is in Stephen's patch).
To explain it: especially switches (like the one in that is modified
here) are in great danger to grow very unwieldy.

  But you are maintaining and developing the GUI(s), so I leave it
for you to decide.

> Besides that, it's OK and I will add MP_TITLE to the X11/GTK GUI as well.

  Fine :)

Greetings,
  Alexander