[MPlayer-dev-eng] GUI and vo_x11_create_vo_window()

[Ingo Brückl]

Reimar Döffinger wrote on Thu, 18 Aug 2011 20:08:16 +0200:

> On Thu, Aug 18, 2011 at 05:38:37PM +0200, Ingo Brückl wrote:
>> Which one is prefered?

> Neither.

Too bad. I don't want to argue, but I thought at least #1 would be a clean
solution as vo_x11_create_vo_window() seems to be prepared to receive a
VOFLAG_FULLSCREEN flag, so why can't the GUI set it within its window
preparation, in an intentional gui() call?

> You either didn't say clearly or I missed it, but I guess what
> you miss is MPlayer doing aspect scaling.

Yep.

> Well, the code to do that even when vo_fs is not set is already there,
> see libvo/video_out.h, aspect_scaling().

Yes, I know.

> It just needs to be hooked up to do something more intelligent than
> just returning vo_fs.

What do you mean by "hooked up"? The function's just returning vo_fs was
the reason for my suggestions, but I'd be glad about any other solution that
would make calc_src_dst_rects() call aspect() and panscan_calc_windowed(). I
just don't know whether/how this could be achieved. If you please could put
me in the right way (other than "forget about GUI start in fullscreen
mode")...

Ingo