[MPlayer-dev-eng] [PATCH] x11_common: XChangeProperty uses long for 32-bits

[Ingo Brückl]

Alexander Strasser wrote on Wed, 17 Aug 2011 19:35:17 +0200:

>> long prop = pid;

>   Also if someone sees where this approach could be seriously
> flawed, please speak up.

I try to ask again, although my first comment was in reply to Nicolas George.

Shouldn't it be:

  CARD32 prop = pid;

>From what I understand when looking at the X11 header files, CARD32 is the
data type to be used for XA_CARDINAL, 32. CARD32 is long on 32-bit and int on
64-bit machines.

If I'm wrong I might at least learn something here.

Ingo