[MPlayer-dev-eng] GUI and vo_x11_ewmh_fullscreen()

[Ingo Brückl]

Reimar Döffinger wrote on Wed, 17 Aug 2011 21:49:11 +0200:

>> #3: Add a parameter (the window ID) to vo_x11_ewmh_fullscreen().

> Should be ok. The only thing I don't like much is that
> vo_x11_ewmh_fullscreen probably really should be static, it
> doesn't seem to be used anywhere outside x11_common.c right now.

Same should apply for vo_x11_decoration() and vo_x11_sizehint() (used by the
GUI in fullscreen context as well).

>> #4: Copy the vo_x11_ewmh_fullscreen() code to the gui code and call the gui
>>     version of it.

> Not really good, but since it's really little code that isn't much of
> a problem either.

> I guess between these it might really depend on whether you want that
> vo_fs_type & vo_wm_FULLSCREEN check or not...
> If you want your own GUI setting for it copying it might be better.

The GUI already checks for vo_fs_type & vo_wm_FULLSCREEN and uses
own code in case that's false, so I don't really would need the check
in vo_x11_ewmh_fullscreen().

As long as the GUI is still meshed with the MPlayer code, I'd prefer #3,
and even when it has got separated in the future, it would send a "go
fullscreen" request to MPlayer, so the code shouldn't be copied to the
GUI part.

However, we could add

  #ifndef CONFIG_GUI
  static
  #endif

to these functions as a reminder why they aren't static although they could
be and we wouldn't forget that when the time of the GUI/MPlayer separation
has come. (Unless this is considered to be ugly.)

Ingo