[MPlayer-dev-eng] [PATCH] x11_common: XChangeProperty uses long for 32-bits

[Reimar Döffinger]

On Mon, Aug 15, 2011 at 07:10:48PM +0200, Nicolas George wrote:
> I found this patch while arguing with someone on whether OpenBSD's MPlayer
> maintainer is reporting the patches upstream. It looks correct, although I
> do not have access to a 64-bits big-endian box to check that it actually
> changes something.

I think it really needs to be tested on a 64-bit big-endian system,
because on such one only one of these can work.
There are also questions about what should happen if pid_t is 64 bit
on 32-bit system?
In general what if the type is not compatible with long?
Is it possible that the proposed change would not even compile.
Should maybe a union {pid_t pid; long arg;} be used?
And lastly: What is that code good for anyway??
Because my opinion is that this is a really crappy and broken
API and it would be preferable to just not support it and remove
that code. If it's important maybe someone will make the effort
of making a non-broken replacement.

Reimar