[MPlayer-dev-eng] [PATCH] libavfilter wrapper

[Nicolas George]

Le sextidi 26 thermidor, an CCXIX, Reimar Döffinger a écrit :
> Have you tested combining it with ordinary MPlayer filters?

A few, those I thought of and know how to use and test. It seems to mostly
work.

> Also, the function to get a buffer is suboptimal, it doesn't
> set all flags and choosing the "NUMBERED" type currently means
> no DR will be possible at all.

That's one point I was not sure about. I added a hack to try to use the
correct type.

As a side note, this part of mplayer lacks documentation. If someone could
find time to say a few words about that, that would be really useful: what
are the real meaning of the various IMGTYPE, what is the best interface for
filters (get/set_image? start/draw_slice?)?

> Otherwise I don't really feel like reviewing it, I don't think
> it can break anything so once you have a bit of documentation
> it's ok for me if you commit.

I do not think the filter can break anything, but I am less sure about the
changes to the build system: they are not long, but I would appreciate if
someone else has a look at them.

Here is an updated version. According to a remark from Stefano, I made the
filter optional and disabled by default: that way, if libavfilter's API
changes, mplayer will still be buildable by default.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-enable-libavfilter.patch
Type: text/x-diff
Size: 3827 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110815/bec22cdb/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libmpcodec-add-vf_lavfi.patch
Type: text/x-diff
Size: 19199 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110815/bec22cdb/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110815/bec22cdb/attachment-0001.asc>