[MPlayer-dev-eng] [PATCH] Fix for mpeg2 A/V sync bug.

[Steaphan Greene]

On 08/12/2011 06:53 PM, compn wrote:
> On Fri, 12 Aug 2011 17:53:14 -0400, Steaphan Greene wrote:
>> On 08/06/2011 02:42 AM, Reimar Döffinger wrote:
>>> On 5 Aug 2011, at 23:49, Steaphan Greene <sgreene at cs.binghamton.edu> wrote:
>>>
>>>> I have the opposite problem from you (Reimar).  I don't have any file
>>>> where this hack does any GOOD.  It just does nothing, or breaks stuff,
>>>> as far as I can tell from my testing.
>>>
>>> I don't know any case where it does any good, I thought you or someone else had.
>>> If not I think we are in agreement to remove that code.
>>
>> Assuming this, combined with otherwise silence, indicates a consensus, I
>> have attached a patch (to SVN r33986) that removes just this part of
>> that commit.  I have tested it and confirmed it resolves the problem
>> with my NTSC DVDs.
> 
> did you test other files (avi / mkv etc) to see if it breaks anything?

Yes, I tried it on a wide variety of sample files using various
container, encodings, and frame-rates.  As far as I can tell the code
removed by this patch just caused problems, and solved nothing.  Without
it, all the samples I play sync up fine.


> a sample or someone to confirm this problem would be nice.

Unfortunately, my samples are all DVDs, and are all license-restricted
so I can't make even partial copies available.  As I understand it, any
NTSC-encoded MPEG2 content, using frame duplication for soft telecine
should show the same problem without this patch, and should sync fine
with it.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt