[MPlayer-dev-eng] [PATCH] make vo_corevideo visible on all Spaces

[Rowan James]

On 22/04/2011, at 1:35 AM, Diego Biurrun wrote:

> On Tue, Apr 19, 2011 at 11:53:19PM +1000, Rowan James wrote:
>> On 19/04/2011, at 9:33 PM, Diego Biurrun wrote:
>> 
>>> On Tue, Apr 19, 2011 at 08:39:29PM +1000, Rowan James wrote:
>>>> 
>>>> Attached is a patch to make the CoreVideo output visible on all Spaces
>>>> (OS X workspace-switching desktops).
>>> 
>>> Why would anybody want that?  It defeats the purpose of multiple
>>> desktops...
>> 
>> Well, I want it to keep what I'm watching in a small window while I switch
>> between other desktops (scratching the proverbial itch).
>> 
>> I'd be perfectly happy to add a '-sticky' option or '-vo corevideo:sticky'
>> parameter, or some such.
> 
> We can talk about that, but I believe this would be a wrong default :)

Most likely it isn't a good default, as you say.  As Erik points out, on OS X the application controls this kind window behaviour.

I'd appreciate any guidance on what type of option this should be, what it should be called, or where to look for an example.

Since I believe it can be modified trivially at runtime, should there be a binding available to hot-key it?

>>>> While the patch itself is quite small (one line, and the condition
>>>> to check for OS X 10.5 or later where the API became available); I'm
>>>> unsure if it should have an option to enable this or not.
>>> 
>>> Would it even work on 10.4?
>> 
>> If built with the 10.5 or newer SDK (so the constant used was defined) it
>> should be fine; the message name, etc. is resolved when used at runtime,
>> so it would throw an exception on older platforms *if* the version check
>> wasn't used to bypass it.
> 
> OK, I'll have to trust you on this one given that my Mac has died.

I've been considering this, and I'm not sure if my current approach is going to cause issues.  While it would run on 10.4, I don't know if somebody running 10.4 could use the 10.5 SDK to build it.

I can't find any docs as to which versions are supposed to be supported for building/running.  I guess at a pinch somebody building on 10.4 could disable it and use -vo quartz instead.

The listed OS X maintainer is 'None', and Core Video isn't even listed with the supported output drivers on the info page of the website (I assume it's just out of date?  Or is CoreVideo still 'beta' or something?)

As a side note, Core Video was introduced in 10.4; but was at the time a part of the QuartzCore framework.

Regards,
Rowan James